QualityMetrics: store use_valid_periods param#4596
Open
alejoe91 wants to merge 49 commits into
Open
Conversation
alejoe91
changed the title
use_valid_perioss paramuse_valid_periods param
Comment on lines
120
to
+121
| if periods is not None: | ||
| raise ValueError("If use_valid_periods is True, periods should not be provided.") | ||
| periods = self.sorting_analyzer.get_extension("valid_unit_periods").get_data(outputs="numpy") | ||
| provided_periods = cast_periods_to_unit_period_dtype(np.asarray(periods)) |
Member
There was a problem hiding this comment.
Is there a reason for allowing the user to pass use_valid_periods and periods now? Something to do with reloading??
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if
use_valid_periodsis given, theperiodsare retrieved from thevalid_unit_periodsextensions and stored as params, but this adds an ambiguity since there is no way to tell a posteriori if periods used for computing quality metrics were actually valid unit periods or externally defined periods. This PR simply propagates the param so it gets saved to the extension.